Switch the semconv migration default to new#6899
Merged
MrAlias merged 19 commits intoopen-telemetry:mainfrom Apr 8, 2025
Merged
Switch the semconv migration default to new#6899MrAlias merged 19 commits intoopen-telemetry:mainfrom
MrAlias merged 19 commits intoopen-telemetry:mainfrom
Conversation
dmathieu
force-pushed
the
semconv-default-dup
branch
from
8c76268 to
71c225f
Compare
dmathieu
force-pushed
the
semconv-default-dup
branch
from
ce8ba58 to
e8d0ac8
Compare
dmathieu
force-pushed
the
semconv-default-dup
branch
from
e8d0ac8 to
e334be7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6899 +/- ##
=======================================
- Coverage 81.0% 80.7% -0.3%
=======================================
Files 205 205
Lines 18098 18083 -15
=======================================
- Hits 14667 14604 -63
- Misses 3000 3060 +60
+ Partials 431 419 -12
🚀 New features to boost your workflow:
|
MrAlias
approved these changes
Mar 15, 2025
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
AyseGokmen
reviewed
Mar 17, 2025
AyseGokmen
left a comment
AyseGokmen
left a comment
There was a problem hiding this comment.
The new convention http.client.request.duration.seconds might still be recording the metrics in milliseconds and with the histogram buckets that would fit the milliseconds use case. Can we please update them as well when switching the default to the new convention?
Member
Author
|
Thank you. I have extracted your report into #6941 |
akats7
approved these changes
Mar 17, 2025
pellared
reviewed
Mar 25, 2025
pellared
approved these changes
Mar 26, 2025
Contributor
|
@XSAM PTAL |
XSAM
approved these changes
Apr 8, 2025
github-project-automation
Bot
moved this from In Progress
to Done
in Go: HTTP Semconv Migration
This was referenced Jul 25, 2025
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This switches the semantic conventions migration default from the old version to be the new one, and keeps the possibility to use
http/dupto get both.Note: we previously tested and documented an
oldconfig.That worked because it used the default. However, that behavior is not documented in the semconv migration spec, and allowing to keep using the old values only when the next release will entirely drop their support looks like a bad idea.
This also removes the
v1.20.0_test.gofiles. Those tests rely on the global server/client, but only tests the old behavior.We can't run the old behavior only anymore, so running those would require a non-trivial refactoring that seems unneeded since this entire code will be removed in the next release.
Closes #6897